Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slat order on drag reorder #4710

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix slat order on drag reorder #4710

merged 1 commit into from
Aug 30, 2024

Conversation

stuartromanek
Copy link
Member

Summary

  • Fixes order on drag reorder

What are the specific steps to test this change?

  1. find an array schema field, add some stuff, drag to reorder

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@stuartromanek stuartromanek merged commit ad53144 into main Aug 30, 2024
8 checks passed
@stuartromanek stuartromanek deleted the fix-slatlist-drag-order branch August 30, 2024 18:58
haroun added a commit that referenced this pull request Sep 3, 2024
* main:
  PRO-6477 undhandled promise errors (#4700)
  fix slat order (#4710)
  make apostoggle accessible (#4708)
  Improve context menu positions (#4706)
  remove focus blockers in page relationship editor (#4702)
haroun added a commit to haroun/apostrophe that referenced this pull request Sep 16, 2024
* upstream/main: (77 commits)
  PRO-6578: auto import of inline images (apostrophecms#4723)
  Inline array improvements (apostrophecms#4671)
  take credit for the fix as well as the "change" (apostrophecms#4725)
  PRO-6576 fix default values for object fields in widgets and generally unify newInstance implementations (apostrophecms#4722)
  release 4.7.0 (apostrophecms#4717)
  allows to render widgets in published mode (for non localized with pu… (apostrophecms#4709)
  fix subfield imports (it was a bug in fetchRelationships: false) (apostrophecms#4715)
  Add replaces configuration for editor context menus (apostrophecms#4714)
  bump uploadfs dep (apostrophecms#4712)
  add batch operations to pages (apostrophecms#4684)
  PRO-6477 undhandled promise errors (apostrophecms#4700)
  fix slat order (apostrophecms#4710)
  make apostoggle accessible (apostrophecms#4708)
  Improve context menu positions (apostrophecms#4706)
  remove focus blockers in page relationship editor (apostrophecms#4702)
  Release 4.6.1 mergeback (apostrophecms#4703)
  remove z-index bump on area schema fields, boost menu index (apostrophecms#4699)
  Pro 6345 fix deprecated sass (apostrophecms#4640)
  Keep widget focused when menu is open (apostrophecms#4695)
  skipReplace for changeDocIds (apostrophecms#4694)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants